fix(agent): clear ordered thinking replay state on signature recovery - #70107

Thanks for tracing the ordered-block replay channel. The premise holds on current main: agent/conversation_loop.py:3942-3945 strips only reasoning_details, while agent/anthropic_adapter.py:2044-2102 preferentially replays non-empty anthropic_content_blocks; agent/chat_completion_helpers.py:1541-1551 stores that channel on assistant messages.

Problems

• tests/run_agent/test_thinking_sig_recovery_persistence.py mirrors the stripping loop rather than invoking agent/conversation_loop.py:3936-3957 and the Anthropic conversion path. It therefore cannot catch a wiring regression where the production retry still replays anthropic_content_blocks.

Suggested changes

• Add a real-path recovery test that verifies the retry wire payload drops both fields, canonical messages retain both fields, and convert_messages_to_anthropic() cannot select the ordered replay path for that retry.

This is an automated hermes-sweeper review.

This was generated by AI during triage.

Summary

Two open PRs address the same invalid signed-thinking replay failure during signature recovery. #24407 strips thinking blocks from canonical messages, while #70107 clears both replay channels from API-time copies and preserves canonical history.

Related pull requests

• fix(agent): strip thinking blocks from content arrays on signature recovery #24407 duplicate — (+145/-7) — verify verdict: n/a: The diff removes thinking and redacted_thinking blocks from assistant content arrays and clears reasoning_details, directly targeting the content-array failure, but mutates canonical messages and tests a reproduced loop rather than the production retry/conversion path. The automated keep-open verdict records medium salvageability and identifies moving the filtering to api_messages plus a real-path test as necessary.
• fix(agent): clear ordered thinking replay state on signature recovery #70107 related — (+48/-10) — verify verdict: n/a: The diff removes reasoning_details and anthropic_content_blocks from shallow-copied api_messages, addressing the ordered replay channel while leaving canonical messages unchanged; its tests still mirror the stripping loop instead of exercising production retry and Anthropic conversion. The automated keep-open verdict records high salvageability and requests a real-path test covering the clean wire payload, preserved canonical state, and disabled ordered replay.

Duplicates

#24407 and #70107 substantially overlap: both target repeated HTTP 400 failures caused by replayed signed thinking state during recovery. #24407 is the broader content-array variant; #70107 targets the current API-time ordered-replay architecture.

Suggested consolidation

Keep open #70107 with a salvage path: retain its API-time clearing of both replay channels and add the requested real-path retry/conversion test. Close #24407 as duplicate of #70107 after preserving its content-array diagnosis; this differs from #24407's automated keep-open verdict, but the recorded diff shows canonical-history mutation and the same fix must be relocated to the API-time path.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    subgraph Dup24407 ["PRs duplicating each other"]
        P24407["PR #24407 (open)"]
        P70107["PR #70107 (open)"]
    end
    class P24407 open
    class P70107 open
    class P70107 target
    click P24407 "https://github.com/NousResearch/hermes-agent/pull/24407"
    click P70107 "https://github.com/NousResearch/hermes-agent/pull/70107"

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 2 pull requests and 0 issues in this complex. Each diff was read against this issue; Assessment working set: 15 kB of PR diffs, 5 kB of issue/PR text, 0 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

Updated with real-path test coverage as requested by @teknium1 and triage review.

The new test_recovery_strips_ordered_blocks_from_retry_wire_payload exercises the production path:

1. Before recovery: builds assistant message with both reasoning_details and anthropic_content_blocks (signed thinking + tool_use), then calls convert_messages_to_anthropic() — confirms the ordered-block fast path fires and replays signed thinking.
2. After recovery: shallow-copies to api_messages, strips both fields, calls convert_messages_to_anthropic() again — confirms the ordered-block fast path does NOT fire (no thinking block in output), while tool_use survives via reconstruction from tool_calls.
3. Canonical messages: verifies both fields are still intact on the original messages list.

Rebased onto current upstream/main (70db671). All 5 tests pass.